Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong resolve path in example #2056

Closed
kwanLeeFrmVi opened this issue Mar 14, 2024 · 1 comment · Fixed by #2072
Closed

wrong resolve path in example #2056

kwanLeeFrmVi opened this issue Mar 14, 2024 · 1 comment · Fixed by #2072

Comments

@kwanLeeFrmVi
Copy link

Link to the documentation page or resource

https://docs.strapi.io/dev-docs/deployment/nginx-proxy#redirecting-landing-page-to-admin-panel

Describe the bug

./config/middlewares.js
module.exports = ({ env }) => [
    // ...
    { resolve: '../src/middlewares/admin-redirect' },
];

the resolve path should be
{ resolve: './src/middlewares/admin-redirect' },

Additional context

No response

Suggested improvements or fixes

No response

Related issue(s)/PR(s)

No response

@SpeedAD
Copy link
Contributor

SpeedAD commented Apr 3, 2024

Hey @pwizla !
We conversed on #1948! I was able to fork the repo, and make the changes. I went through the CONTRIBUTING.md.
As I completed my changes I saw this PR #2057 . I think this is still open and doesn't solve the issue?

I have raised my PR here: #2072

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants