Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memberlite Banner meta box Gutenberg compatibility #7

Closed
kimcoleman opened this issue Oct 5, 2018 · 4 comments
Closed

Memberlite Banner meta box Gutenberg compatibility #7

kimcoleman opened this issue Oct 5, 2018 · 4 comments

Comments

@kimcoleman
Copy link
Member

When using Gutenberg, the TinyMCE editor teatareas fail to save the content.

Disabling the TinyMCE editor and using a basic textarea form input properly saves and validates.

@pbrocks
Copy link
Contributor

pbrocks commented Nov 7, 2018

This issue is addressed in this PR: #9

@ideadude ideadude closed this as completed Nov 7, 2018
@ideadude
Copy link
Member

ideadude commented Nov 9, 2018

The earlier fix simply disabled Gutenberg which we don't want.

This seems related to the Gutenberg issue here: WordPress/gutenberg#7176 and here WordPress/gutenberg#8762

Going to try to fix in WP Core.

@ideadude ideadude reopened this Nov 9, 2018
@pbrocks
Copy link
Contributor

pbrocks commented Nov 14, 2018

We can use the full range of tinyMCE in the editor as long as when you publish or update you are viewing the Text tab, ie you see the html text in the editor, not WYSIWYG

Sreencast showing how we can save in Memberlite Elements metaboxes

@ideadude
Copy link
Member

ideadude commented Dec 3, 2018

If WP 5.0 doesn't include the fix for this, we will merge in this commit which fixes this 29eaf4f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants