unordered_base: Fix corner case in bucket computation #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Fibonacci Hashing is used, the result of the bucket function may exceed the bucket count in case of a bucket count of 1. This is due to a bit shift by 64 that will be performed in this case which leads to undefined/unreliable behavior. Handle this corner case by explicitly returning the only possible bucket position, i.e. return 0 in this case. Furthermore, use
std::size_t
instead ofsize_t
to improve the consistency.