Improve tsconfig.app.json detection for app/angular #6940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroeder
added
angular
patch:yes
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-issue6934-ngsb-extends-wrong-tsconfig.storybook.now.sh |
shilman
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #6934
What I did
I improved the
tsconfig.app.jsondetection as it was broken because of a breaking change in Angular 8. They movedtsconfig.app.jsonfromsrc/tsconfig.app.jsonto./tsconfig.app.jsonI changed it so that it reads the correct path from
angular.jsoninstead of setting a fixed path. That way every Angular version should be compatibleHow to test
lib/clisb init -fa project and check if it can start