Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: merge global parameters #6900

Merged
merged 3 commits into from
Jun 3, 2019
Merged

feat: merge global parameters #6900

merged 3 commits into from
Jun 3, 2019

Conversation

mortal94
Copy link
Contributor

What I did

deep merge options property when using addParameters to add global parameters.

How to test

  • Is this testable with Jest or Chromatic screenshots?
    -> Yes. added test cases.

@vercel
Copy link

vercel bot commented May 28, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@vercel vercel bot temporarily deployed to staging May 28, 2019 14:58 Inactive
@mortal94 mortal94 changed the title Feat - override options feat: override options May 28, 2019
@mortal94 mortal94 changed the title feat: override options feat: merge global parameters May 28, 2019
@shilman shilman added this to the 5.1.0 milestone May 28, 2019
shilman
shilman approved these changes May 28, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mortal94
Copy link
Contributor Author

mortal94 commented Jun 2, 2019

Hey @shilman , can you tell me when are you going to release this fix? thanks!

@shilman
Copy link
Member

shilman commented Jun 3, 2019

@mortal94 Thanks for the nudge -- I'd forgotten to merge it. Releasing today.

@shilman shilman merged commit ca7bfe8 into storybookjs:next Jun 3, 2019
@mortal94 mortal94 deleted the feat-override-options branch June 3, 2019 06:45
@shilman
Copy link
Member

shilman commented Jun 3, 2019

@mortal94 https://github.com/storybookjs/storybook/releases/tag/v5.1.0-rc.4

@mortal94
Copy link
Contributor Author

mortal94 commented Jun 3, 2019

@mortal94 https://github.com/storybookjs/storybook/releases/tag/v5.1.0-rc.4

Awesome! thanks @shilman ! 🎉

@dependencies dependencies bot mentioned this pull request Jan 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

@shilman shilman shilman approved these changes

Assignees
No one assigned
Labels
core feature request
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mortal94 @shilman @ndelangen