-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon-contexts improvements: bug-fixing, testing, typing #6572
Conversation
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-add-addon-contexts-tests.storybook.now.sh |
@shilman... the automation bot seems a bit crazy here... Did I do something wrong or you think it could be a bug 😢... |
Codecov Report
@@ Coverage Diff @@
## next #6572 +/- ##
========================================
+ Coverage 40.1% 40.6% +0.49%
========================================
Files 633 633
Lines 8660 8660
Branches 619 620 +1
========================================
+ Hits 3473 3516 +43
+ Misses 5098 5055 -43
Partials 89 89
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## next #6572 +/- ##
========================================
+ Coverage 40.1% 40.61% +0.5%
========================================
Files 633 633
Lines 8660 8660
Branches 619 620 +1
========================================
+ Hits 3473 3517 +44
+ Misses 5098 5054 -44
Partials 89 89
Continue to review full report at Codecov.
|
@leoyli It's because you tagged this |
Issue: #6559
What I did
param
in a context carryingprops = null
, it mistakenly disable the context.How to test
Addon|Contexts
stories in the official storybook (should not break the stories).UPDATE: