Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge addon-contexts into the monorepo #6559

Merged
merged 202 commits into from
Apr 18, 2019
Merged

Merge addon-contexts into the monorepo #6559

merged 202 commits into from
Apr 18, 2019

Conversation

leoyli
Copy link
Contributor

@leoyli leoyli commented Apr 18, 2019

Issue: https://github.com/leoyli/addon-contexts

What I did

  • Fix some bugs (storybook tab switches / story-level configs).
  • Fix typing, prettier, linting errors, example story snapshots to get a green build.
  • Add some WHY comments for people interested in the source code.
  • Add 2 stories under Addon | Contexts in our official Storybook (React), clicking here to see it.

There were many bad git issues so I close and reopen this PR to remove noises. Please let me know if you have any feedback!

@vercel
Copy link

vercel bot commented Apr 18, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-add-addon-contexts.storybook.now.sh

@leoyli
Copy link
Contributor Author

leoyli commented Apr 18, 2019

It seems I have a hard time with the yarn.lock file 😠.

@ndelangen ndelangen self-assigned this Apr 18, 2019
@codecov
Copy link

codecov bot commented Apr 18, 2019

Codecov Report

Merging #6559 into next will decrease coverage by 0.57%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #6559      +/-   ##
==========================================
- Coverage   40.69%   40.11%   -0.58%     
==========================================
  Files         616      633      +17     
  Lines        8534     8657     +123     
  Branches      600      619      +19     
==========================================
  Hits         3473     3473              
- Misses       4972     5095     +123     
  Partials       89       89
Impacted Files Coverage Δ
addons/contexts/src/preview/libs/functionals.ts 0% <0%> (ø)
addons/contexts/src/preview/frameworks/react.ts 0% <0%> (ø)
addons/contexts/src/constants.ts 0% <0%> (ø)
addons/contexts/src/register.ts 0% <0%> (ø)
addons/contexts/src/manager/ToolBarMenuOptions.tsx 0% <0%> (ø)
addons/contexts/src/preview/libs/getPropsMap.ts 0% <0%> (ø)
addons/contexts/src/manager/ToolbarControl.tsx 0% <0%> (ø)
addons/contexts/src/preview/frameworks/vue.ts 0% <0%> (ø)
addons/contexts/src/preview/index.ts 0% <0%> (ø)
...ddons/contexts/src/preview/libs/getRendererFrom.ts 0% <0%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f93649...7103e56. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 18, 2019

Codecov Report

Merging #6559 into next will decrease coverage by 0.57%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #6559      +/-   ##
==========================================
- Coverage   40.69%   40.11%   -0.58%     
==========================================
  Files         616      633      +17     
  Lines        8534     8657     +123     
  Branches      600      619      +19     
==========================================
  Hits         3473     3473              
- Misses       4972     5095     +123     
  Partials       89       89
Impacted Files Coverage Δ
addons/contexts/src/preview/libs/functionals.ts 0% <0%> (ø)
addons/contexts/src/preview/frameworks/react.ts 0% <0%> (ø)
addons/contexts/src/constants.ts 0% <0%> (ø)
addons/contexts/src/register.ts 0% <0%> (ø)
addons/contexts/src/manager/ToolBarMenuOptions.tsx 0% <0%> (ø)
addons/contexts/src/preview/libs/getPropsMap.ts 0% <0%> (ø)
addons/contexts/src/manager/ToolbarControl.tsx 0% <0%> (ø)
addons/contexts/src/preview/frameworks/vue.ts 0% <0%> (ø)
addons/contexts/src/preview/index.ts 0% <0%> (ø)
...ddons/contexts/src/preview/libs/getRendererFrom.ts 0% <0%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f93649...7103e56. Read the comment docs.

@leoyli
Copy link
Contributor Author

leoyli commented Apr 18, 2019

I finally get a build really really green... yarn.lock file is really a black magic to me :'(

@ndelangen, @shilman: any suggestions!? Could we merge it! 😸

@leoyli
Copy link
Contributor Author

leoyli commented Apr 18, 2019

I'm going to merge it since @ndelangen reviewed and approved. Meanwhile, I'm going to deprecate my published NPM pkg once it became available in a stable release (perhaps v5.1?!). If possible, I think we can briefly announce this addon in v5.1 releasing press so the community may know about it (What do you think, @shilman).

My next step is to add tests and url param feature, then push this addon toward Angular community. 💪

@leoyli leoyli merged commit 73ed4f2 into next Apr 18, 2019
@leoyli leoyli deleted the add/addon-contexts branch April 18, 2019 16:18
@shilman
Copy link
Member

shilman commented Apr 19, 2019

@leoyli Def worth an announcement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants