-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge addon-contexts into the monorepo #6559
Conversation
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-add-addon-contexts.storybook.now.sh |
It seems I have a hard time with the |
7acf05a
to
7103e56
Compare
Codecov Report
@@ Coverage Diff @@
## next #6559 +/- ##
==========================================
- Coverage 40.69% 40.11% -0.58%
==========================================
Files 616 633 +17
Lines 8534 8657 +123
Branches 600 619 +19
==========================================
Hits 3473 3473
- Misses 4972 5095 +123
Partials 89 89
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## next #6559 +/- ##
==========================================
- Coverage 40.69% 40.11% -0.58%
==========================================
Files 616 633 +17
Lines 8534 8657 +123
Branches 600 619 +19
==========================================
Hits 3473 3473
- Misses 4972 5095 +123
Partials 89 89
Continue to review full report at Codecov.
|
I finally get a build really really green... @ndelangen, @shilman: any suggestions!? Could we merge it! 😸 |
I'm going to merge it since @ndelangen reviewed and approved. Meanwhile, I'm going to deprecate my published NPM pkg once it became available in a stable release (perhaps v5.1?!). If possible, I think we can briefly announce this addon in v5.1 releasing press so the community may know about it (What do you think, @shilman). My next step is to add tests and url param feature, then push this addon toward Angular community. 💪 |
@leoyli Def worth an announcement! |
Issue: https://github.com/leoyli/addon-contexts
What I did
Addon | Contexts
in our official Storybook (React), clicking here to see it.There were many bad git issues so I close and reopen this PR to remove noises. Please let me know if you have any feedback!