Fixed Colorblindness Emulation #6297
Conversation
Codecov Report
@@ Coverage Diff @@
## next #6297 +/- ##
==========================================
- Coverage 38.29% 38.27% -0.02%
==========================================
Files 648 648
Lines 9839 9844 +5
Branches 387 387
==========================================
Hits 3768 3768
- Misses 6011 6016 +5
Partials 60 60
Continue to review full report at Codecov.
|
|
Thank you! |
Which snapshots? The only test I see for this addon is for the |
| @@ -8,6 +8,16 @@ import { Icons, IconButton, WithTooltip, TooltipLinkList } from '@storybook/comp | |||
|
|
|||
| const getIframe = memoize(1)(() => document.getElementById('storybook-preview-iframe')); | |||
|
|
|||
| const getFilter = (filter: string | null) => { | |||
| if (filter === null) { | |||
There was a problem hiding this comment.
It could, but I wanted to be "strict" and consistent, since the reset is this.setFilter(null); and there's a similar check if (filter !== null) {
shilman
added
patch:yes
|
Oh, of course. TeamCity build confused me. |
shilman
added
the
patch:done
Issue: #5959
What I did
display: none, but Firefox won't render filters that are set todisplay: none(see https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/display and https://benfrain.com/applying-multiple-svg-filter-effects-defined-in-css-or-html/), so I've used the position absolute no sizes technique.filter: url("#null")tofilter: none, since Firefox doesn't render filters that are not found (and the code doesn't have a filter with idnull) while the correct property in css isnone(see https://developer.mozilla.org/en-US/docs/Web/CSS/filter)activeproperty to the selection list, to show the selected filterHow to test
Run storybook in Firefox and use the Colorblindness selection list