-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds an example of a boolean knob #6242
Conversation
proves that the boolean knob works as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @joefraley Is this currently working? Or did you add it to show that knobs boolean is broken?
As an aside, most of the time we look at official-storybook
. Never hurts to add an example to a specific view layer tho.
Codecov Report
@@ Coverage Diff @@
## next #6242 +/- ##
=======================================
Coverage 38.12% 38.12%
=======================================
Files 645 645
Lines 9647 9647
Branches 355 355
=======================================
Hits 3678 3678
Misses 5914 5914
Partials 55 55 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## next #6242 +/- ##
=======================================
Coverage 38.12% 38.12%
=======================================
Files 645 645
Lines 9647 9647
Branches 355 355
=======================================
Hits 3678 3678
Misses 5914 5914
Partials 55 55 Continue to review full report at Codecov.
|
verified it locally and fixed it, can you confirm @joefraley ? |
proves that the boolean knob works as expected
Issue:
What I did
How to test
If your answer is yes to any of these, please make sure to include it in your PR.