Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(knobs): color type button z-index #6203

Merged
merged 1 commit into from
Mar 20, 2019
Merged

fix(knobs): color type button z-index #6203

merged 1 commit into from
Mar 20, 2019

Conversation

Armanio
Copy link
Member

@Armanio Armanio commented Mar 20, 2019

Issue: #6184

What I did

Set knob button zIndex to 3 on color picker is showed

How to test

Create multiple colors knob
Click not last in the list
Profi!

For more information, see screenshots:
Before (@Zyzle screenshot):
image

After:
Снимок экрана 2019-03-20 в 22 30 00

  • Is this testable with Jest or Chromatic screenshots?
    no
  • Does this need a new example in the kitchen sink apps?
    no
  • Does this need an update to the documentation?
    no

@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Mar 20, 2019
@shilman shilman added this to the 5.0.x milestone Mar 20, 2019
shilman
shilman approved these changes Mar 20, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @Armanio

@codecov
Copy link

codecov bot commented Mar 20, 2019 •
edited
Loading

Codecov Report

Merging #6203 into next will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #6203      +/-   ##
==========================================
+ Coverage   38.13%   38.13%   +<.01%     
==========================================
  Files         645      645              
  Lines        9643     9644       +1     
  Branches      355      355              
==========================================
+ Hits         3677     3678       +1     
  Misses       5911     5911              
  Partials       55       55
Impacted Files Coverage Δ
addons/knobs/src/components/types/Color.js 29.62% <100%> (+2.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bdb2ca...c3ca208. Read the comment docs.

@shilman shilman merged commit 033757e into storybookjs:next Mar 20, 2019
@Armanio Armanio deleted the fix/knob_color branch March 20, 2019 20:34
@shilman shilman mentioned this pull request Mar 20, 2019
Closed
@shilman shilman added patch:done Patch/release PRs already cherry-picked to main/release branch and removed patch:done Patch/release PRs already cherry-picked to main/release branch labels Mar 23, 2019
shilman added a commit that referenced this pull request Mar 23, 2019
@shilman
Merge pull request #6203 from Armanio/fix/knob_color
425f80d 
fix(knobs): color type button z-index
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@alexandrebodin alexandrebodin Awaiting requested review from alexandrebodin

@alterx alterx Awaiting requested review from alterx

@Hypnosphi Hypnosphi Awaiting requested review from Hypnosphi

@leonrodenburg leonrodenburg Awaiting requested review from leonrodenburg

@theinterned theinterned Awaiting requested review from theinterned

Assignees
No one assigned
Labels
addon: knobs bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
5.0.x
Development

Successfully merging this pull request may close these issues.
2 participants
@Armanio @shilman