-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #6077: issue with selectedPanel reset #6149
Conversation
Codecov Report
@@ Coverage Diff @@
## next #6149 +/- ##
=========================================
+ Coverage 37.9% 38.29% +0.38%
=========================================
Files 645 643 -2
Lines 9642 9420 -222
Branches 354 1344 +990
=========================================
- Hits 3655 3607 -48
+ Misses 5940 5254 -686
- Partials 47 559 +512
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and great job on the test cases 👌 Thanks so much for taking care of this!
I see a conflict, looks like |
@malykhinvi yes please! 🙏 |
@shilman done! |
Issue: #6077
What I did
Added check for
options.selectedPanel
presence, so that if it isundefined
it won't reset the currently selected panel.How to test