Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecations in examples #6134

Merged
merged 1 commit into from
Mar 17, 2019
Merged

Fix deprecations in examples #6134

merged 1 commit into from
Mar 17, 2019

Conversation

aamct2
Copy link
Contributor

@aamct2 aamct2 commented Mar 17, 2019

Issue: #4501

What I did

  • Went through all of the projects in examples and fixed any deprecation warnings logged in the console

How to test

Launch each example project and check the console for deprecation warnings.

@shilman shilman added the maintenance User-facing maintenance tasks label Mar 17, 2019
@shilman shilman added this to the v5.1.0 milestone Mar 17, 2019
shilman
shilman approved these changes Mar 17, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aamct2 You are a saint! 🙏

@shilman shilman merged commit dd791c9 into storybookjs:next Mar 17, 2019
@shilman shilman mentioned this pull request Mar 17, 2019
Closed
@aamct2 aamct2 deleted the fix-deprecations branch March 17, 2019 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@Hypnosphi Hypnosphi Awaiting requested review from Hypnosphi

@ndelangen ndelangen Awaiting requested review from ndelangen

@usulpro usulpro Awaiting requested review from usulpro

Assignees
No one assigned
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@aamct2 @shilman