Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aria label to search box #6131

Merged
merged 1 commit into from
Mar 17, 2019
Merged

Add aria label to search box #6131

merged 1 commit into from
Mar 17, 2019

Conversation

aamct2
Copy link
Contributor

@aamct2 aamct2 commented Mar 17, 2019

Issue: #6130

What I did

  • Added aria-label to search box
  • Re-generated the Jest snapshots

How to test

  • Is this testable with Jest or Chromatic screenshots? Yes
  • Does this need a new example in the kitchen sink apps? No
  • Does this need an update to the documentation? No

@Armanio
Copy link
Member

Armanio commented Mar 17, 2019

Looks good! 👍

@Armanio Armanio merged commit 26ef1a7 into storybookjs:next Mar 17, 2019
@aamct2 aamct2 deleted the fix-search-aria branch March 17, 2019 10:03
@shilman shilman mentioned this pull request Mar 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielduan danielduan Awaiting requested review from danielduan

@Hypnosphi Hypnosphi Awaiting requested review from Hypnosphi

@igor-dv igor-dv Awaiting requested review from igor-dv

@ndelangen ndelangen Awaiting requested review from ndelangen

@tmeasday tmeasday Awaiting requested review from tmeasday

@usulpro usulpro Awaiting requested review from usulpro

Assignees
No one assigned
Labels
accessibility bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aamct2 @Armanio