bug fix (addons/viewport): viewport iframe dimensions #5993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `boxSizing: 'content-box'` to override the global box-sizing rule and allow the storybook preview iframe to have the specified dimensions from the viewport addon config. Fixes storybookjs#5927
shilman
added
bug
addon: viewport
patch:yes
|
Good catch and simple fix! Thanks!!! 🎊 |
Codecov Report
@@ Coverage Diff @@
## next #5993 +/- ##
=======================================
Coverage 34.93% 34.93%
=======================================
Files 648 648
Lines 9515 9515
Branches 1351 1380 +29
=======================================
Hits 3324 3324
Misses 5574 5574
Partials 617 617
Continue to review full report at Codecov.
|
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Mar 11, 2019
bug fix (addons/viewport): viewport iframe dimensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #5927
What I did
Use
boxSizing: 'content-box'to override the global box-sizing ruleand allow the storybook preview iframe to have the specified dimensions
from the viewport addon config.
Fixes #5927
How to test
Before. Incorrect viewport iframe size:
After. Corrected viewport iframe size:
No (but I don't actually know).
No.
No.