Fix Angular global style imports #5776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o angular.json for angular cli
gaetanmaisse
approved these changes
Feb 26, 2019
shilman
added a commit
that referenced
this pull request
Feb 27, 2019
Fix Angular global style imports
shilman
added a commit
that referenced
this pull request
Feb 27, 2019
Fix Angular global style imports
This was referenced Feb 27, 2019
|
@shilman This seems like it is a fix for Angular 6 and up with notes of only looking at angular.json? what about pre angular 6 with using ".angular-cli.json"? |
|
@mikepaggi AFAIK |
Where is that mentioned anywhere in the documentation? All I see is Angular support with support with using the CLI. So far I haven't seen anything spit out errors when i was installing initially or when running it. As much as there is support for Angular...the docs are very lacking :-( |
shilman
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #4378 #5239
This is @yjcxy12 's PR #5525 with the conflicts resolved. I was unable to push the resolution to his branch due to some github bug around github actions (since the merge contained edits to
main.workflow... don't ask). So I branched and resolved conflicts here. Please direct any further discussion to that PR.