Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #5665
What I did
#5733 does not appear to work as advertised. When I modify
official-storybook
in thenext
branch as follows:It uses the URL and uses
Foo
as the alt text. However I expect to see the text "Foo" instead of Storybook.This fix forces the
brandImage
theme var tonull
when using the deprecated options, which showsFoo
but hides the image entirely. Not sure this is the behavior we want, but it's an improvement.How to test
See above