Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated url/name options #5773

Merged
merged 1 commit into from
Feb 26, 2019
Merged

Fix deprecated url/name options #5773

merged 1 commit into from
Feb 26, 2019

Conversation

shilman
Copy link
Member

@shilman shilman commented Feb 26, 2019

Issue: #5665

What I did

#5733 does not appear to work as advertised. When I modify official-storybook in the next branch as follows:

addParameters({
  options: {
    name: 'Foo',
    url: 'https://github.com',
  }
});

It uses the URL and uses Foo as the alt text. However I expect to see the text "Foo" instead of Storybook.

This fix forces the brandImage theme var to null when using the deprecated options, which shows Foo but hides the image entirely. Not sure this is the behavior we want, but it's an improvement.

How to test

See above

@tmeasday
Copy link
Member

Seems like the right thing to me.

@codecov
Copy link

codecov bot commented Feb 26, 2019

Codecov Report

Merging #5773 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            next   #5773   +/-   ##
=====================================
  Coverage   33.5%   33.5%           
=====================================
  Files        647     647           
  Lines       9400    9400           
  Branches    1364    1364           
=====================================
  Hits        3149    3149           
  Misses      5633    5633           
  Partials     618     618
Impacted Files Coverage Δ
lib/ui/src/core/init-provider-api.js 21.42% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1234a02...ad9a2db. Read the comment docs.

@shilman shilman merged commit 1e1cd12 into next Feb 26, 2019
@shilman shilman deleted the 5665-fix-deprecated-options branch February 26, 2019 10:03
shilman added a commit that referenced this pull request Feb 27, 2019
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants