Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGE animation duration for layout && ADD animation for toolbar #5742

Merged
merged 2 commits into from
Feb 25, 2019

Conversation

ndelangen
Copy link
Member

Just a bit of polish

@codecov
Copy link

codecov bot commented Feb 25, 2019

Codecov Report

Merging #5742 into next will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #5742   +/-   ##
=======================================
  Coverage   33.31%   33.31%           
=======================================
  Files         648      648           
  Lines        9372     9372           
  Branches     1356     1331   -25     
=======================================
  Hits         3122     3122           
  Misses       5635     5635           
  Partials      615      615
Impacted Files Coverage Δ
lib/ui/src/components/preview/components.js 100% <ø> (ø) ⬆️
lib/ui/src/components/layout/container.js 20.37% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5d1728...774c534. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 25, 2019

Codecov Report

Merging #5742 into next will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #5742   +/-   ##
=======================================
  Coverage   33.31%   33.31%           
=======================================
  Files         648      648           
  Lines        9372     9372           
  Branches     1356     1331   -25     
=======================================
  Hits         3122     3122           
  Misses       5635     5635           
  Partials      615      615
Impacted Files Coverage Δ
lib/ui/src/components/preview/components.js 100% <ø> (ø) ⬆️
lib/ui/src/components/layout/container.js 20.37% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5d1728...774c534. Read the comment docs.

@ndelangen ndelangen requested a review from domyen February 25, 2019 10:02
Copy link
Member

@domyen domyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@domyen domyen merged commit b7beef8 into next Feb 25, 2019
@domyen domyen deleted the feature/toolbar-toggle-animation branch February 25, 2019 16:16
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Feb 27, 2019
shilman pushed a commit that referenced this pull request Feb 27, 2019
…tion

CHANGE animation duration for layout && ADD animation for toolbar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request patch:done Patch/release PRs already cherry-picked to main/release branch ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants