Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX a11y setup being undefined #5724

Merged
merged 1 commit into from
Feb 22, 2019
Merged

FIX a11y setup being undefined #5724

merged 1 commit into from
Feb 22, 2019

Conversation

ndelangen
Copy link
Member

Issue: a11y config when not set can cause an error

What I did

Fix it by adding a default config of {}

@ndelangen ndelangen added this to the v5.0.0 milestone Feb 22, 2019
@ndelangen ndelangen self-assigned this Feb 22, 2019
@ndelangen
Copy link
Member Author

@shilman

@codecov
Copy link

codecov bot commented Feb 22, 2019

Codecov Report

Merging #5724 into next will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #5724      +/-   ##
==========================================
- Coverage   33.28%   33.27%   -0.01%     
==========================================
  Files         648      648              
  Lines        9371     9372       +1     
  Branches     1330     1355      +25     
==========================================
  Hits         3119     3119              
- Misses       5637     5638       +1     
  Partials      615      615
Impacted Files Coverage Δ
addons/a11y/src/index.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6e283f...4728ac0. Read the comment docs.

@shilman shilman merged commit b434355 into next Feb 22, 2019
@shilman shilman deleted the fix/a11y-config branch February 22, 2019 16:01
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: a11y bug patch:done Patch/release PRs already cherry-picked to main/release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants