Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-a11y: Fix buggy scroll behavior #5713

Merged
merged 1 commit into from
Feb 21, 2019

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Feb 21, 2019

Issue: #5598

ADD options to a11y addon so it's doesn't do buggy buggy stuff
MOVE the scrollTop to after the component rendered
ADD stories to test the behavior properly

… buggy buggy stuff

MOVE the scrollTop to after the component rendered
ADD stories to test the behavior properly
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 well done @ndelangen

@tmeasday tmeasday merged commit 2aec970 into next Feb 21, 2019
@tmeasday tmeasday deleted the fix/scrolling-down-on-storychange branch February 21, 2019 21:13
@shilman shilman changed the title Fix the damn scrolly scrolly buggy buggy stuff Addon-a11y: Fix buggy scroll behavior Feb 22, 2019
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Feb 22, 2019
shilman pushed a commit that referenced this pull request Feb 22, 2019
…hange

Fix the damn scrolly scrolly buggy buggy stuff
@ndelangen
Copy link
Member Author

#5598

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants