Fix ie 11 #5599
Merged
Fix ie 11 #5599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 15, 2019 13:08
The `URL` class is not properly supported in IE11. In this case we actually didn't need that prop for these stories. In general we should use something like https://github.com/jsdom/whatwg-url if we want a `URL` in a story.
tmeasday
requested review from
Hypnosphi,
igor-dv and
ndelangen
as code owners
Closed
shilman
added a commit
that referenced
this pull request
Feb 15, 2019
shilman
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Latest version didn't work in IE11 as the
URLclass is not properly supported.In this case we actually didn't need that prop for these stories. In general we should use something like https://github.com/jsdom/whatwg-url if we want a
URLin a story.#5590
What I did
Removed
locationfrom stories, and fixed the mobile layout to not pass it unnecessarily to the preview.How to test
Test this branch on IE11 - https://fix-ie-11--storybooks-official.netlify.com
If your answer is yes to any of these, please make sure to include it in your PR.