Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for when outputDir is an absolute path #5573

Merged
merged 2 commits into from
Feb 14, 2019

Conversation

petersendidit
Copy link
Contributor

Issue: Absolute path output in build-storybook doesn't work as expected #5334

What I did

Added a check for outputDir to see if its a absolute path already before trying to resolve it into one.

How to test

Set --output-path to an absolute path

  • Is this testable with Jest or Chromatic screenshots? not that I know of
  • Does this need a new example in the kitchen sink apps? no
  • Does this need an update to the documentation? no

If your answer is yes to any of these, please make sure to include it in your PR.

@codecov
Copy link

codecov bot commented Feb 14, 2019

Codecov Report

Merging #5573 into next will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            next   #5573   +/-   ##
=====================================
  Coverage   33.2%   33.2%           
=====================================
  Files        647     647           
  Lines       9315    9315           
  Branches    1325    1325           
=====================================
  Hits        3093    3093           
  Misses      5607    5607           
  Partials     615     615
Impacted Files Coverage Δ
lib/core/src/server/build-static.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5158d13...b6bd5c1. Read the comment docs.

@ndelangen ndelangen added the bug label Feb 14, 2019
@ndelangen
Copy link
Member

Nice find, and nice solution, Thank you @petersendidit!

@ndelangen ndelangen merged commit 6730b4d into storybookjs:next Feb 14, 2019
@petersendidit petersendidit deleted the FixAbsoluteOutputPath branch February 15, 2019 00:09
shilman pushed a commit that referenced this pull request Feb 15, 2019
fix for when outputDir is an absolute path
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants