Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V5 style refinements #5562

Merged
merged 18 commits into from
Feb 13, 2019
Merged

V5 style refinements #5562

merged 18 commits into from
Feb 13, 2019

Conversation

tmeasday
Copy link
Member

Various style fixes for v5

Note I had to pass --no-verify to commit, the error was:

'/Users/tom/OSS/storybook/.ci/danger/dangerfile.ts' is not included in project.

this is not related to this branch but perhaps a problem with current next?

domyen and others added 18 commits February 8, 2019 18:35
@domyen
Tweak theme variable names && continue fixing theme variable names
7f74926
@domyen
SidebarHeading: Add styles that limit img sizes for users brands
0cb3196
@domyen
Start theming dark mode
07e933f
@domyen
Use createGlobal instead of createReset because colors are inherited …
287442a 
…from body

@ndelangen this messes with the grid plugin but setting body background and color is a common pattern to support. e.g., when theming a dark mode ;)
@domyen
Merge branch 'v5-style-refinements' of https://github.com/storybooks/…
ba50ba3 
…storybook into v5-style-refinements
@domyen
StorybookLogo now inherits currentColor of the site
21ef40a
@domyen
Use the theme for actions addon styling
8a6552a
@domyen
Adjust layout of Knobs && remove hardcoded fontsizes
63a3a7f
@domyen
Syntax colors respond to light vs dark themes
852a34b
@domyen
Simplify Button API && refactor Form.Button to better use theme varia…
12fc1cf 
…bles
@domyen
SidebarItem and SidebarSubheading use theme vars
681a3f4
@domyen
Update snapshot tests
3351de1
@domyen
Update Placeholder story
9f74a9b
@domyen
Dark theme QA and cleanup
9a50e80
@domyen
Remove hoverable effects on Button
8b0376c
@domyen
Add some WIP docs (need help QAing and writing these) & uncomment dar…
fa0377f 
…k.ts theme
@domyen
Update snapshots
9bf18c6
@tmeasday
Merge remote-tracking branch 'origin/next' into v5-style-refinements
70b7e43
@tmeasday tmeasday requested a review from shilman February 13, 2019 00:34
@tmeasday tmeasday added bug ui patch:yes Bugfix & documentation PR that need to be picked to main branch labels Feb 13, 2019
shilman
shilman requested changes Feb 13, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine and I'm merging for the sake of expediting the release. However I have some concerns about theming:

@domyen

Most (all?) of the components now have a light-grey background, e.g.

https://www.chromaticqa.com/snapshot?appId=5a375b97f4b14f0020b0cda3&id=5c636b7e8b2da10024880e55

https://www.chromaticqa.com/snapshot?appId=5a375b97f4b14f0020b0cda3&id=5c636b7e8b2da10024880df1

I'm pretty sure this is a mistake but can you please verify and fix in a subsequent PR if it's indeed a problem?

@ndelangen @domyen cc @tmeasday

Not specifically related to this PR, but why are we exposing ThemeVars to the user and then transforming them, e.g. colorPrimary => color.primary? If we're using the same schema up and down the stack doesn't make it easier to write new components and debug themes?

@shilman shilman merged commit db6ed03 into next Feb 13, 2019
@shilman shilman added patch:done Patch/release PRs already cherry-picked to main/release branch release and removed patch:yes Bugfix & documentation PR that need to be picked to main branch labels Feb 15, 2019
@shilman
Copy link
Member

shilman commented Feb 19, 2019

@tmeasday @domyen FYI this didn't actually get released yet. Releasing it now in RC.3

shilman added a commit that referenced this pull request Feb 19, 2019
@shilman
Merge pull request #5562 from storybooks/v5-style-refinements
7f8bcf4 
V5 style refinements
@Hypnosphi Hypnosphi deleted the v5-style-refinements branch February 23, 2019 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman requested changes

@alexandrebodin alexandrebodin Awaiting requested review from alexandrebodin

@alterx alterx Awaiting requested review from alterx

@danielduan danielduan Awaiting requested review from danielduan

@Hypnosphi Hypnosphi Awaiting requested review from Hypnosphi

@igor-dv igor-dv Awaiting requested review from igor-dv

@jbovenschen jbovenschen Awaiting requested review from jbovenschen

@leonrodenburg leonrodenburg Awaiting requested review from leonrodenburg

@ndelangen ndelangen Awaiting requested review from ndelangen

@theinterned theinterned Awaiting requested review from theinterned

@usulpro usulpro Awaiting requested review from usulpro

Assignees

@shilman shilman

Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tmeasday @shilman @ndelangen @domyen