Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] addon-notes and addon-cssresources unavailable on initial load #5514

Merged
merged 2 commits into from
Feb 8, 2019

Conversation

pgoforth
Copy link
Contributor

@pgoforth pgoforth commented Feb 7, 2019

Issue:
#5418

What I did

  • Changed STORY_CHANGED to STORY_RENDERED in addon-notes
  • Changed STORY_CHANGED to STORY_RENDERED in addon-cssresources
  • Updated README for addon-cssresources to clarify implementation
  • Updated writing-addons docs to reflect event change

- Changed `STORY_CHANGED` to `STORY_RENDERED` in `addon-notes`
- Changed `STORY_CHANGED` to `STORY_RENDERED` in `addon-cssresources`
- Updated README for `addon-cssresources`
- Updated writing-addons docs to reflect event change:
@storybook-safe-bot
Copy link
Contributor

storybook-safe-bot commented Feb 7, 2019

Fails
🚫

PR is not labeled with one of: ["cleanup","doc-dependencies:update","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies:update","dependencies","other"]

Generated by 🚫 dangerJS against e914c98

@pgoforth pgoforth changed the title Defect fixes for addon onload functionality [bug] addon-notes and addon-cssresources unavailable on initial load Feb 7, 2019
@ndelangen
Copy link
Member

That's quite in a first PR @pgoforth ! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants