Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX keybindings were pointing to null events #5375

Merged
merged 1 commit into from
Jan 27, 2019
Merged

Conversation

Jessica-Koch
Copy link
Contributor

Issue:

What I did

Some of the storybook keybindings were mapped to mistyped shortcuts, I fixed the incorrect mapping and also passed additonal keyboard event properties in the event object that I will need.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@codecov
Copy link

codecov bot commented Jan 26, 2019

Codecov Report

Merging #5375 into next will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #5375      +/-   ##
==========================================
+ Coverage   30.37%   30.38%   +<.01%     
==========================================
  Files         622      621       -1     
  Lines        8957     8956       -1     
  Branches     1229     1229              
==========================================
  Hits         2721     2721              
+ Misses       5579     5578       -1     
  Partials      657      657
Impacted Files Coverage Δ
lib/ui/src/settings/shortcuts.js 95.83% <ø> (ø) ⬆️
lib/ui/src/core/shortcuts.js 19% <ø> (ø) ⬆️
lib/ui/src/containers/nav.js 11.76% <ø> (ø) ⬆️
lib/core/src/client/preview/start.js 72.61% <0%> (ø) ⬆️
lib/theming/src/themes/light-syntax.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7517f2d...e7bdda6. Read the comment docs.

Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@storybook-safe-bot
Copy link
Contributor

Fails
🚫

PR is not labeled with one of: ["cleanup","doc-dependencies:update","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies:update","dependencies","other"]

Generated by 🚫 dangerJS against e7bdda6

@tmeasday tmeasday merged commit db3bf63 into next Jan 27, 2019
@tmeasday tmeasday deleted the keybinding-labels branch January 27, 2019 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants