Fix issue where "Tab" => []. #5374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invalid shortcuts should map to null.
tmeasday
requested review from
Hypnosphi,
igor-dv and
ndelangen
as code owners
Jessica-Koch
approved these changes
Jan 26, 2019
Codecov Report
@@ Coverage Diff @@
## next #5374 +/- ##
==========================================
+ Coverage 30.37% 30.38% +<.01%
==========================================
Files 622 621 -1
Lines 8957 8956 -1
Branches 1229 1230 +1
==========================================
Hits 2721 2721
+ Misses 5579 5578 -1
Partials 657 657
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invalid shortcuts should map to null.
Issue: Tabbing away from shortcuts set them to empty (#5373)