Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD a STORY_UNCHANGED event #5340

Merged
merged 1 commit into from
Jan 23, 2019
Merged

ADD a STORY_UNCHANGED event #5340

merged 1 commit into from
Jan 23, 2019

Conversation

tmeasday
Copy link
Member

Emit when the STORY_RENDER event is received but nothing has changed, so we aren't re-rendering.

This helps tools like Chromatic detect with certainty when a story has finished rendering

Emit when the STORY_RENDER event is received but nothing has changed, so we aren't re-rendering.
@tmeasday tmeasday requested a review from ndelangen January 23, 2019 05:18
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAY 🎉

@codecov
Copy link

codecov bot commented Jan 23, 2019

Codecov Report

Merging #5340 into next will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #5340      +/-   ##
==========================================
+ Coverage   30.08%   30.08%   +<.01%     
==========================================
  Files         619      619              
  Lines        9001     9003       +2     
  Branches     1230     1248      +18     
==========================================
+ Hits         2708     2709       +1     
- Misses       5628     5629       +1     
  Partials      665      665
Impacted Files Coverage Δ
lib/core/src/client/preview/start.js 76.25% <0%> (-0.97%) ⬇️
lib/core-events/src/index.ts 100% <100%> (ø) ⬆️
lib/theming/src/themes/dark-syntax.ts
lib/theming/src/themes/light-syntax.ts 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e48631e...3f3f0af. Read the comment docs.

@ndelangen ndelangen merged commit 1b5b407 into next Jan 23, 2019
@ndelangen ndelangen added this to the v5.0.0 milestone Jan 23, 2019
@ndelangen ndelangen deleted the add-STORY_UNCHANGED branch May 7, 2019 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants