Release 5.0 #5222

shilman · 2019-01-12T05:10:54Z

What I did

Merge 5.0 release branch into next now that the tests are passing

Released this on debug NPM tag as 5.0.0-debug.3

How to test

yarn test
cd examples/official-storybook
yarn storybook

…alue if nothing is in respective input, change error handling

…to tech/overhaul-ui

# Conflicts: # .eslintrc.js # addons/notes/package.json # addons/notes/src/index.ts # addons/notes/src/register.js # yarn.lock

…to tech/overhaul-ui

…rhaul-ui

…to tech/overhaul-ui

…ies tracking

# Conflicts: # addons/a11y/package.json # addons/actions/package.json # addons/backgrounds/package.json # addons/cssresources/package.json # addons/events/package.json # addons/info/package.json # addons/info/src/__snapshots__/index.test.js.snap # addons/jest/package.json # addons/knobs/package.json # addons/notes/package.json # addons/viewport/package.json # app/react/package.json # examples/cra-kitchen-sink/package.json # examples/official-storybook/config.js # examples/official-storybook/package.json # lib/components/package.json # lib/components/src/layout/desktop.js # lib/components/src/layout/index.js # lib/core/package.json # lib/ui/package.json # lib/ui/src/modules/ui/components/search_box.js # lib/ui/src/modules/ui/components/shortcuts_help.js # lib/ui/src/modules/ui/components/stories_panel/__snapshots__/index.stories.storyshot # lib/ui/src/modules/ui/components/stories_panel/__snapshots__/text_filter.stories.storyshot # lib/ui/src/modules/ui/components/stories_panel/stories_tree/__snapshots__/index.stories.storyshot # lib/ui/src/modules/ui/components/stories_panel/stories_tree/tree_decorators.js # package.json # yarn.lock

# Conflicts: # addons/a11y/package.json # addons/actions/package.json # addons/backgrounds/package.json # addons/cssresources/package.json # addons/events/package.json # addons/google-analytics/package.json # addons/info/package.json # addons/jest/package.json # addons/knobs/package.json # addons/links/package.json # addons/notes/package.json # addons/storyshots/storyshots-core/package.json # addons/viewport/package.json # app/react/package.json # examples/cra-kitchen-sink/package.json # examples/official-storybook/package.json # examples/official-storybook/stories/addon-info.stories.js # lib/addons/package.json # lib/channel-websocket/package.json # lib/core/package.json # lib/ui/package.json

codecov · 2019-01-12T07:14:22Z

Codecov Report

Merging #5222 into next will decrease coverage by 5.48%.
The diff coverage is 13.4%.

@@            Coverage Diff             @@
##             next    #5222      +/-   ##
==========================================
- Coverage   35.53%   30.05%   -5.49%     
==========================================
  Files         597      608      +11     
  Lines        7423     8823    +1400     
  Branches     1012     1275     +263     
==========================================
+ Hits         2638     2652      +14     
- Misses       4281     5439    +1158     
- Partials      504      732     +228

Impacted Files	Coverage Δ
app/svelte/src/client/preview/index.js	`0% <ø> (ø)`	⬆️
addons/knobs/src/components/types/Select.js	`84.61% <ø> (ø)`	⬆️
addons/knobs/src/components/types/Object.js	`20% <ø> (ø)`	⬆️
app/angular/src/server/options.js	`0% <ø> (ø)`	⬆️
addons/viewport/src/defaults.js	`0% <ø> (ø)`
addons/info/src/components/PropTable.js	`96.77% <ø> (ø)`	⬆️
app/react/src/server/options.js	`0% <ø> (ø)`	⬆️
app/polymer/src/client/preview/index.js	`0% <ø> (ø)`	⬆️
addons/ondevice-backgrounds/src/BackgroundPanel.js	`0% <ø> (ø)`	⬆️
app/react/src/client/preview/render.js	`7.69% <ø> (ø)`	⬆️
... and 344 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96d9d92...05f771b. Read the comment docs.

…lease/5.0

Hypnosphi · 2019-01-12T10:31:53Z

^5.0.0-alpha.N will match 5.0.0-debug =(

shilman · 2019-01-13T03:24:47Z

@Hypnosphi OUCH--sorry about that! I guess that means we'll have to get it out of alpha quickly. Or people will just have to use the @next tag. FML.

Any ideas what we should do next time around?

shilman · 2019-01-13T04:18:37Z

I took two shortcuts to get this building:

Downgraded react-syntax-highlighter in addon-cssresources due to some version conflict with 5.0 components cc @nm123github
Commented out cra-svgr.stories.js App.stories.js due to an SVGR / storyshots issue cc @igor-dv

Hypnosphi · 2019-01-13T13:28:46Z

@shilman beta is lower than debug as well. But honestly, using a caret when depending on a pre-release is a bad idea anyway

Hypnosphi · 2019-01-13T13:30:19Z

Any ideas what we should do next time around?

Use any word that stands before alpha alphabetically =). Or just release first couple of alphas when debugging

tmeasday · 2019-01-13T23:24:06Z

`aalpha`? 😂

…

On 14 Jan 2019, 12:30 AM +1100, Filipp Riabchun ***@***.***>, wrote: > Any ideas what we should do next time around? Use any word that stands before alpha alphabetically =) — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or mute the thread.

Hypnosphi · 2019-01-14T00:14:05Z

@tmeasday adebug

tmeasday · 2019-01-14T00:32:15Z

👌

SimenB · 2019-01-14T12:07:41Z

Reminds me of https://github.com/ReactiveX/rxjs/blob/master/CHANGELOG.md#600-tactical-rc1-2018-04-07 😀

In the meantime, could you do a dist-tag with delta or something? Or rc? Just to avoid the issue, even though I agree one should not necessarily use semver ranges on pre-releases

tmeasday · 2019-01-15T01:44:07Z

We're looking to do an rc pretty soon anyway, so hopefully this particular example will be a non-event ;)

ndelangen and others added 30 commits December 6, 2018 23:55

OPTIMIZE treeview state

87de564

UPGRADE addon-background usage to use parameters everywhere

9f65a57

#3984 clear input when focusing, save on blur, and restores default v…

e735ede

…alue if nothing is in respective input, change error handling

#3984 change event handler

1b0da95

Merge branch 'next' into tech/overhaul-ui

ba4780d

Merge branch 'tech/overhaul-ui' of github.com:storybooks/storybook in…

9bfcd1a

…to tech/overhaul-ui

Merge branch 'next' into tech/overhaul-ui

9eb3cae

# Conflicts: # .eslintrc.js # addons/notes/package.json # addons/notes/src/index.ts # addons/notes/src/register.js # yarn.lock

#3984 persist keyboard shortcuts, update styles, add success handler

07bfcc5

REFACTOR addon-notes

f793237

Merge branch 'tech/overhaul-ui' of github.com:storybooks/storybook in…

2fbace1

…to tech/overhaul-ui

REFACTOR a11y addon && FIX issues with decorators reloading

ec82d04

MODIFY option to use addParameters

a1762d7

FIX a11y issue

2761750

migrated to ts

4c5345d

REFACTOR state management

a8bf858

Merge commit '4c5345d15cadb33e0277d399963c27bcee3b7623' into tech/ove…

43e3bda

…rhaul-ui

FIX option in story to hide panels

deb174f

#3984 reduce code redundancy

ba3de9b

FIX iframe business, get the iframe once

22059f9

IMPROVE typescript types on addon-notes

c066e41

Merge branch 'tech/overhaul-ui' of github.com:storybooks/storybook in…

ab06d36

…to tech/overhaul-ui

WIP

7d7d21e

REFACTOR addon-links

a9d3564

REFACTOR addon-googleAnalytics && ADD error tracking and missing stor…

63da588

…ies tracking

CLEANUP

51c176c

#3984 fix code so that it detcts modifier keys and keypresses

9b229e3

#3984 fix pushing duplicate keys

03522a5

#3984 fix doubly adding key shortcuts to api

3b7de6d

shilman requested review from rmevans9, saponifi3d, stijnkoopal, theinterned, thomasbertet, tmeasday, usulpro and z4o4z as code owners January 12, 2019 05:10

v5.0.0-debug.2

7d7fcb3

shilman added 3 commits January 12, 2019 15:14

Merge branch 'release/5.0' of github.com:storybooks/storybook into re…

598ce9a

…lease/5.0

Update versions?

b52822a

v5.0.0-debug.3

7e9669a

Merge branch 'next' into release/5.0

01f4b88

shilman added 4 commits January 13, 2019 12:48

Move keyboard utils - shouldn't import from src

96a484c

Fix bad merge

407a542

Try to fix storyshots

8bec7e4

Fix broken smoke test

05f771b

shilman merged commit 99223b1 into next Jan 13, 2019

shilman deleted the release/5.0 branch January 13, 2019 06:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 5.0 #5222

Release 5.0 #5222

shilman commented Jan 12, 2019 •

edited

Loading

codecov bot commented Jan 12, 2019 •

edited

Loading

Hypnosphi commented Jan 12, 2019

shilman commented Jan 13, 2019 •

edited

Loading

shilman commented Jan 13, 2019 •

edited

Loading

Hypnosphi commented Jan 13, 2019

Hypnosphi commented Jan 13, 2019 •

edited

Loading

tmeasday commented Jan 13, 2019 via email

Hypnosphi commented Jan 14, 2019 •

edited

Loading

tmeasday commented Jan 14, 2019

SimenB commented Jan 14, 2019

tmeasday commented Jan 15, 2019

Release 5.0 #5222

Release 5.0 #5222

Conversation

shilman commented Jan 12, 2019 • edited Loading

What I did

How to test

codecov bot commented Jan 12, 2019 • edited Loading

Codecov Report

Hypnosphi commented Jan 12, 2019

shilman commented Jan 13, 2019 • edited Loading

shilman commented Jan 13, 2019 • edited Loading

Hypnosphi commented Jan 13, 2019

Hypnosphi commented Jan 13, 2019 • edited Loading

tmeasday commented Jan 13, 2019 via email

Hypnosphi commented Jan 14, 2019 • edited Loading

tmeasday commented Jan 14, 2019

SimenB commented Jan 14, 2019

tmeasday commented Jan 15, 2019

shilman commented Jan 12, 2019 •

edited

Loading

codecov bot commented Jan 12, 2019 •

edited

Loading

shilman commented Jan 13, 2019 •

edited

Loading

shilman commented Jan 13, 2019 •

edited

Loading

Hypnosphi commented Jan 13, 2019 •

edited

Loading

Hypnosphi commented Jan 14, 2019 •

edited

Loading