Migrate @storybook/client-logger to TypeScript #5151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
approved these changes
Jan 5, 2019
Codecov Report
@@ Coverage Diff @@
## next #5151 +/- ##
=======================================
Coverage 35.24% 35.24%
=======================================
Files 596 596
Lines 7396 7396
Branches 1010 1015 +5
=======================================
Hits 2607 2607
Misses 4276 4276
Partials 513 513
Continue to review full report at Codecov.
|
kroeder
reviewed
Jan 6, 2019
lib/client-logger/package.json
Outdated
| @@ -15,7 +15,7 @@ | |||
| }, | |||
| "license": "MIT", | |||
| "main": "dist/index.js", | |||
| "jsnext:main": "src/index.js", | |||
| "types": "src/index.d.ts", | |||
There was a problem hiding this comment.
This should be dist/index.d.ts I think?
There was a problem hiding this comment.
Fixed this – thanks for pointing it out.
added 2 commits
January 6, 2019 11:05
… exclude paths to exclude tests.
…orybook into ts-migration/client-logger
kroeder
approved these changes
Jan 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #5030
What I did
Migrated
@storybook/client-loggerto TypeScriptHow to test
Existing tests were retained in
lib/client-logger/src/index.test.ts