Storyshots: Fix async issue with obtaining custom Puppeteer instance … #5130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gidztech
requested review from
Hypnosphi,
igor-dv and
thomasbertet
as code owners
gidztech
force-pushed
the
fix_custom_puppeteer_async_issue
branch
from
e8521a4 to
52414f7
Compare
Codecov Report
@@ Coverage Diff @@
## next #5130 +/- ##
==========================================
+ Coverage 35.07% 35.07% +<.01%
==========================================
Files 594 594
Lines 7362 7361 -1
Branches 1007 1001 -6
==========================================
Hits 2582 2582
Misses 4271 4271
+ Partials 509 508 -1
Continue to review full report at Codecov.
|
|
@gidztech I think this is a breaking change, right? |
ndelangen
approved these changes
Jan 3, 2019
|
@ndelangen Technically a breaking change because of the API change, but it wasn't actually working before. |
This was referenced Jan 8, 2019
|
@ndelangen this is a bug fix. For now, it's impossible to use custom puppeteer instance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…(#5069#)
Issue: The
customBrowserconfig option for storyshots-puppeteer doesn't work because Jest doesn't wait for async functions to complete in test files that aren't part of the actual test function. You will get aYour test suite must contain at least one test.error because it doesn't find the tests in the current stack.What I did
Instead of trying to do the async operation outside of the test function, we can pass the function to
initStoryshotsto later be called inside thebeforeAllhook, where Jest will happily wait.I changed
customBrowsertogetCustomBrowser, which is an async function that returns thebrowserinstance. If that function isn't provided in config, the normal launch behaviour remains.