bump puppeteer from 1.9.0 to 1.11.0 #5119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jivanvl
requested review from
Hypnosphi,
igor-dv and
thomasbertet
as code owners
ndelangen
approved these changes
Jan 4, 2019
|
Thanks! |
ndelangen
added
the
patch:yes
shilman
pushed a commit
that referenced
this pull request
Jan 6, 2019
bump puppeteer from 1.9.0 to 1.11.0
shilman
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
To be created, but I'll explain here
At GitLab we're having an issue with puppeteer on our CI environment: https://gitlab.com/gitlab-org/csslab/-/jobs/139386734. Puppeteer fails to run the headless instance, updating puppeteer to 1.11.0 and testing locally with a docker image seem to solve the issue.
What I did
I updated the
package.jsonfile from addon-storyshots to point to the latest puppeteer version.