-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core - Simplify custom webpack config #4927
Conversation
Codecov Report
@@ Coverage Diff @@
## next #4927 +/- ##
==========================================
+ Coverage 35.02% 35.04% +0.02%
==========================================
Files 566 566
Lines 7004 7000 -4
Branches 937 936 -1
==========================================
Hits 2453 2453
+ Misses 4055 4052 -3
+ Partials 496 495 -1
Continue to review full report at Codecov.
|
Generated by 🚫 dangerJS |
Shall we merge this into the overhaul-ui branch? |
What is the recommended way of getting only the absolutely required part of default config now? |
Issue: Partially related to #4903
Today we have an option to extend webpack config by providing the function like this:
Where
defaultConfig
is a few rules bigger than abasicConfig
. I think it brings more confusion rather a benefit.What I did
basicConfig
and changed to the signature to:Why object? Because it's much easier to extend and deprecate in the future.
defaultConfigName
) that is passed forme the frameworks to core. This prop is kinda not needed.