-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-native): Add ability to filter story list from React-Native #4806
feat(react-native): Add ability to filter story list from React-Native #4806
Conversation
Codecov Report
@@ Coverage Diff @@
## next #4806 +/- ##
==========================================
- Coverage 35.53% 35.45% -0.09%
==========================================
Files 560 560
Lines 6829 6845 +16
Branches 916 919 +3
==========================================
Hits 2427 2427
- Misses 3921 3934 +13
- Partials 481 484 +3
Continue to review full report at Codecov.
|
Hey @elucaswork, great job!. Did you test it with android? Both landscape and portrait? Does switching between them with keyboard open works correctly? :) This is a great new feature. Moving forward we want to try to do a POC of displaying story list as webview, maybe that would allow us to reuse the code from the web part. It would also give us an option for collapsable story list. |
sections={data} | ||
stickySectionHeadersEnabled={false} | ||
/> | ||
<React.Fragment> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe lets not use fragment yet? They are only added in React 16.2. It will break backwards compatibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, sure. done._
Since you've been contributing a lot lately, I've added you @elucaswork to the Storybook team! Welcome :) |
…dingView param on preview tab
d7bd102
to
d0d0eba
Compare
Thanks!.
i see. let me know if I can help, somehow.
awesome 🎉 |
Lets see how it will do :) Regarding webview for story list we have to wait till @ndelangen finishes working on refactoring of it so we could use it too. The idea would be to create a mini bundle with code necessary to run the sidebar, then load it in a page and use postmessages to communicate between webview and react native part. |
#3905 is the issue about it. |
Issue: N/A
What I did
KeyboardAvoidingView
to make the story list present the whole list while the filter bar is open. (Basically doing this PR fix(react-native): prevent the Navigation bar to stay underneath the keyboard #4710, but adding an option,shouldDisableKeyboardAvoidingView
, to disable thisKeyboardAvoidingView
, preventing the problem with nestedKeyboardAvoidingView
)KeyboardAvoidingView
fromOnDeviceUI/addons/wrapper.js
. Looks like it's not working, as expected, and know withKeyboardAvoidingView
as Storybook wrapper, it's no longer needed;How to test
If your answer is yes to any of these, please make sure to include it in your PR.