Add missing "forceReRender" and "addParameters" #4767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-dv
added
bug
vue
angular
app: polymer
patch:yes
igor-dv
requested review from
alterx,
kazupon,
leonrodenburg,
naipath,
ndelangen and
thomasbertet
as code owners
Codecov Report
@@ Coverage Diff @@
## next #4767 +/- ##
=======================================
Coverage 35.61% 35.61%
=======================================
Files 557 557
Lines 6776 6776
Branches 904 904
=======================================
Hits 2413 2413
Misses 3893 3893
Partials 470 470
Continue to review full report at Codecov.
|
shilman
added a commit
that referenced
this pull request
Nov 15, 2018
Add missing "forceReRender" and "addParameters"
shilman
added
the
patch:done
This was referenced Dec 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #4762
What I did
Some of the supported apps have a missing forceReRender/addParameters functions. I've added them to the public exports.