Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(textfilter): turn off spell check in story filter #4472

Merged
merged 5 commits into from
Oct 23, 2018

Conversation

danielduan
Copy link
Member

Issue: browser checks the spelling the filter - most of the time, the names of stories are probably not words

What I did

turn filter autocomplete and spellcheck off

How to test

Is this testable with Jest or Chromatic screenshots?
Does this need a new example in the kitchen sink apps?
Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

For maintainers only: Please tag your pull request with at least one of the following:
["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@danielduan danielduan added bug patch:yes Bugfix & documentation PR that need to be picked to main branch labels Oct 17, 2018
@ndelangen ndelangen added this to the v4.0.0 milestone Oct 23, 2018
@ndelangen ndelangen added the ui label Oct 23, 2018
@codecov
Copy link

codecov bot commented Oct 23, 2018

Codecov Report

Merging #4472 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4472   +/-   ##
=======================================
  Coverage   35.59%   35.59%           
=======================================
  Files         557      557           
  Lines        6729     6729           
  Branches      883      883           
=======================================
  Hits         2395     2395           
  Misses       3875     3875           
  Partials      459      459
Impacted Files Coverage Δ
...modules/ui/components/stories_panel/text_filter.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45c4055...c67abf8. Read the comment docs.

@ndelangen ndelangen merged commit c3aa283 into master Oct 23, 2018
@ndelangen ndelangen deleted the dd/spellcheck-off branch October 23, 2018 15:17
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants