Support "mjs" extensions #4466
Merged
Support "mjs" extensions #4466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4466 +/- ##
=======================================
Coverage 35.96% 35.96%
=======================================
Files 555 555
Lines 6653 6653
Branches 871 871
=======================================
Hits 2393 2393
Misses 3813 3813
Partials 447 447
Continue to review full report at Codecov.
|
libetl
reviewed
Oct 17, 2018
| @@ -57,7 +57,7 @@ export default ({ configDir, babelOptions, entries }) => { | |||
| module: { | |||
| rules: [ | |||
| { | |||
| test: /\.jsx?$/, | |||
| test: /\.(mjs|jsx?)$/, | |||
There was a problem hiding this comment.
There is a very edge case : what about the mjsx files ?
There was a problem hiding this comment.
yeah, I could set it to m?jsx?. But do they even exist?
There was a problem hiding this comment.
Let's wait until we hear from the community about this.
libetl
approved these changes
Oct 17, 2018
ndelangen
approved these changes
Oct 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #4125 (comment)
What I did
Added mjs to the prod/dev webpack configs