Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ember] create ember entry point to official storybook #4426

Merged
merged 1 commit into from
Oct 15, 2018

Conversation

gabrielcsapo
Copy link
Contributor

What I did

  • Adds an entry point to the ember example app

@codecov
Copy link

codecov bot commented Oct 15, 2018

Codecov Report

Merging #4426 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4426   +/-   ##
=======================================
  Coverage   35.98%   35.98%           
=======================================
  Files         555      555           
  Lines        6650     6650           
  Branches      871      871           
=======================================
  Hits         2393     2393           
  Misses       3810     3810           
  Partials      447      447

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e43f8a8...830ea98. Read the comment docs.

@gabrielcsapo gabrielcsapo added this to the v4.0.0 milestone Oct 15, 2018
@pksunkara pksunkara merged commit 45c48a5 into master Oct 15, 2018
@pksunkara pksunkara deleted the gabrielcsapo-patch-1 branch October 15, 2018 08:24
@Hypnosphi
Copy link
Member

It should be a symlink not a text file

@pksunkara
Copy link
Member

My bad, github shows symlink like this, so thought this diff contained a symlink. Should have looked at the details.

@pksunkara
Copy link
Member

@gabrielcsapo Can you make a PR fixing this? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants