Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change crna-kitchen-sink path and Some CI maintenance #4409

Merged
merged 2 commits into from
Oct 13, 2018
Merged

Change crna-kitchen-sink path and Some CI maintenance #4409

merged 2 commits into from
Oct 13, 2018

Conversation

pksunkara
Copy link
Member

Also remove HYPERAPP

@codecov
Copy link

codecov bot commented Oct 13, 2018 •
edited
Loading

Codecov Report

Merging #4409 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4409   +/-   ##
=======================================
  Coverage   36.02%   36.02%           
=======================================
  Files         557      557           
  Lines        6643     6643           
  Branches      869      869           
=======================================
  Hits         2393     2393           
  Misses       3805     3805           
  Partials      445      445

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f22b9f...fcabc23. Read the comment docs.

@pksunkara pksunkara added the maintenance User-facing maintenance tasks label Oct 13, 2018
Hypnosphi
Hypnosphi reviewed Oct 13, 2018
View reviewed changes
.teamcity/OpenSourceProjects_Storybook/Project.kt Outdated
buildType(OpenSourceProjects_Storybook_Docs)
buildType(OpenSourceProjects_Storybook_Build_2)
buildType(OpenSourceProjects_Storybook_CliTest)
buildType(OpenSourceProjects_Storybook_Test)
buildType(OpenSourceProjects_Storybook_Lint)
buildType(OpenSourceProjects_Storybook_Lint_Warnings)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't realize we wanted both Lint giving warnings and error. Any reason behind that?

Copy link
Member

@Hypnosphi Hypnosphi Oct 13, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Lint" blocks merging PRs, and "Lint Warnings" doesn't. We don't want to block PR because of wrong indentation, but we want to fix it at some point afterwards. And to fix an issue, we need to know about it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't that be achieved by removing "Lint" from "Build" and make it optional?

Copy link
Member

@Hypnosphi Hypnosphi Oct 13, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eslint doesn't only check formatting. We still want everything that we marked as "error" to be a blocker. E.g. using nonexistent variable or eval()

@pksunkara pksunkara force-pushed the pksunkara/maintenance branch from 3f70b64 to e3bbe42 Compare October 13, 2018 20:01
Hypnosphi
Hypnosphi reviewed Oct 13, 2018
View reviewed changes
...ity/OpenSourceProjects_Storybook/buildTypes/OpenSourceProjects_Storybook_NativeSmokeTests.kt Outdated
uuid = "ac276912-df1a-44f1-8de2-056276193ce8"
id = "OpenSourceProjects_Storybook_ReactNative"
id = "OpenSourceProjects_Storybook_NativeSmokeTests"
name = "React Native"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual displayed name didn't change. Is it intended?

@pksunkara pksunkara force-pushed the pksunkara/maintenance branch from f93ad5d to 7235882 Compare October 13, 2018 20:13
@pksunkara pksunkara force-pushed the pksunkara/maintenance branch from fe9d3d1 to 33f1c59 Compare October 13, 2018 20:15
@pksunkara pksunkara force-pushed the pksunkara/maintenance branch from 33f1c59 to fcabc23 Compare October 13, 2018 20:17
@Hypnosphi Hypnosphi merged commit 7087345 into master Oct 13, 2018
@Hypnosphi Hypnosphi deleted the pksunkara/maintenance branch October 13, 2018 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hypnosphi Hypnosphi Hypnosphi approved these changes

@danielduan danielduan Awaiting requested review from danielduan danielduan is a code owner

@Gongreg Gongreg Awaiting requested review from Gongreg Gongreg is a code owner

@igor-dv igor-dv Awaiting requested review from igor-dv igor-dv is a code owner

@ndelangen ndelangen Awaiting requested review from ndelangen ndelangen is a code owner

Assignees
No one assigned
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pksunkara @Hypnosphi