Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-less api for node #4344

Merged
merged 4 commits into from
Oct 11, 2018
Merged

CLI-less api for node #4344

merged 4 commits into from
Oct 11, 2018

Conversation

igor-dv
Copy link
Member

@igor-dv igor-dv commented Oct 10, 2018

Issue: #4249

What I did

There are cases when people want to run storybook from their code.
I've exposed the "standalone" api, so now it will be possible to do something like this:

import build from '@storybook/react/standalone';

build({
  mode: 'dev',
  port: 9009,
  configDir: './storybook',
  frameworkPresets: [],
});

@codecov
Copy link

codecov bot commented Oct 10, 2018

Codecov Report

Merging #4344 into master will decrease coverage by 0.42%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4344      +/-   ##
==========================================
- Coverage   40.04%   39.62%   -0.43%     
==========================================
  Files         503      519      +16     
  Lines        5903     5966      +63     
  Branches      795      805      +10     
==========================================
  Hits         2364     2364              
- Misses       3156     3209      +53     
- Partials      383      393      +10
Impacted Files Coverage Δ
app/svelte/src/server/build.js 0% <ø> (ø) ⬆️
app/svelte/src/server/index.js 0% <ø> (ø) ⬆️
app/vue/src/server/index.js 0% <ø> (ø) ⬆️
app/html/src/server/index.js 0% <ø> (ø) ⬆️
lib/core/src/server/utils.js 36.36% <ø> (+7.79%) ⬆️
app/marko/src/server/index.js 0% <ø> (ø) ⬆️
app/mithril/src/server/index.js 0% <ø> (ø) ⬆️
app/polymer/src/server/index.js 0% <ø> (ø) ⬆️
app/react/src/server/index.js 0% <ø> (ø) ⬆️
app/ember/src/server/index.js 0% <ø> (ø) ⬆️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c91d502...bb5395f. Read the comment docs.

@ndelangen ndelangen merged commit 95d954e into master Oct 11, 2018
@ndelangen ndelangen deleted the core/extract-cli-out-of-the-build branch October 11, 2018 10:10
@ndelangen ndelangen added this to the v4.0.0 milestone Oct 11, 2018
@igor-dv
Copy link
Member Author

igor-dv commented Oct 11, 2018

Will document it later 😇 I swear

@transitive-bullshit
Copy link
Member

@igor-dv I wasn't aware this was so recent of an addition, but I've found it extremely useful.

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants