Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
The presets API, in the beginning, was to expose these methods: babel, webpack, preview & manager. Each one is about to extend a relevant part in the SB configuration.
After that,
babelDefault
was added to solve the babel 6 compatibility problems and remove the complexity ofbabel-merge
.What I did
From now, the core will expose presets loader that only knows to do the
apply
. Then core will wrap theapply
withbabel
,webpack
,preview
&manager
. Since presets object is passed deeper to the presets chain, any other preset will be able to extend it with the new functionality.