CHANGE index.html.ejs to use files over chunks && UPGRADE generate-page-webpack-plugin #4134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge-webpack-plugin
ndelangen
requested review from
alterx,
danielduan,
Gongreg,
igor-dv,
rmevans9 and
tmeasday
as code owners
diagramatics
reviewed
Sep 8, 2018
| <% if (options.headHtmlSnippet) { %> | ||
| <%- options.headHtmlSnippet %> | ||
| <% } %> | ||
|
|
||
| <% if (options.links) { %> |
There was a problem hiding this comment.
Is there still a point on having options.links when we don't (well, can't) use them?
There was a problem hiding this comment.
Well not really no. we do not expose a way to set this.
Hypnosphi
approved these changes
Sep 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: generate-page-webpack-plugin was using object spread & it now exposes a more reliable entrypoint.getFiles() as
files.This PR upgrades to the latest version & changes the html.ejs template to use the
filesproperty.This implements compatibility with https://github.com/webpack-contrib/mini-css-extract-plugin, possibly other css extraction plugins as well.