-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix centered addon for IE11 #3735
Fix centered addon for IE11 #3735
Conversation
@brianespinosa you might be interested in checking this? |
Looks good but I think this breaks some snapshots so those will need to be updated. @sam-at-work
|
Codecov Report
@@ Coverage Diff @@
## master #3735 +/- ##
==========================================
- Coverage 41.59% 41.32% -0.28%
==========================================
Files 462 459 -3
Lines 5147 5084 -63
Branches 866 853 -13
==========================================
- Hits 2141 2101 -40
+ Misses 2490 2473 -17
+ Partials 516 510 -6 Continue to review full report at Codecov.
|
@danielduan I've updated the snapshots.
but running |
c582da9
to
f0b7885
Compare
@Hypnosphi I'm not sure why the Danger CI is failing, but this looks good to go. |
This Pull Request renovates the package group "storybook monorepo". - [@​storybook/react](https://github.com/storybooks/storybook) (`devDependencies`): from `3.4.7` to `3.4.8` - [@​storybook/addons](https://github.com/storybooks/storybook) (`devDependencies`): from `3.4.7` to `3.4.8` - [@​storybook/addon-links](https://github.com/storybooks/storybook) (`devDependencies`): from `3.4.7` to `3.4.8` - [@​storybook/addon-actions](https://github.com/storybooks/storybook) (`devDependencies`): from `3.4.7` to `3.4.8` # Release Notes <details> <summary>storybooks/storybook</summary> ### [`v3.4.8`](https://github.com/storybooks/storybook/blob/master/CHANGELOG.md#​348) [Compare Source](storybookjs/storybook@v3.4.7...v3.4.8) 2018-June-21 ##### Bug Fixes - Fix centered addon for IE11 [#​3735](`https://github.com/storybooks/storybook/pull/3735`) - Display functions as variables not invocations [#​3761](`https://github.com/storybooks/storybook/pull/3761`) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com).
Issue:
#2525
What I did
Fix the style rules for centered add on so that it works correctly in IE11
How to test
Look at centered add on in IE 11. Components will now be correctly centered