Remove linebreaks in notes text when it are html elements #3731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keraito
requested review from
alexandrebodin,
danielduan,
Hypnosphi and
usulpro
as code owners
Keraito
added
bug
patch:yes
Hypnosphi
approved these changes
Jun 8, 2018
|
Thanks for the fast turn-around on this! |
Hypnosphi
added a commit
that referenced
this pull request
Jun 9, 2018
This was referenced Jun 11, 2018
Closed
Hypnosphi
added
the
patch:done
This was referenced Aug 1, 2018
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Fixes #3724
When the user adds a markdown table to the notes addon, a lot of linebreaks will be created. This is caused at https://github.com/storybooks/storybook/blob/master/addons/notes/src/register.js#L48. The table creates a string of HTML elements, with each of them proceeded by a \n. All of them thus get extended with a
<br />.What I did
Unfortunately, there is no negative lookbehind in js, so instead I added a regex before the existing one to filter out any existing linebreaks if they are immediatly after a HTML element. The detection of HTML elements could be more detailled, if that's prefered.
How to test
Added a new story.