Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed Duplicate declaration h #3409

Merged
merged 7 commits into from
Apr 17, 2018
Merged

fixed Duplicate declaration h #3409

merged 7 commits into from
Apr 17, 2018

Conversation

yi-ge
Copy link
Contributor

@yi-ge yi-ge commented Apr 12, 2018

Issue:

What I did

fixed Duplicate declaration h bug.

How to test

only add "h"

@danielduan danielduan added the bug label Apr 12, 2018
@danielduan
Copy link
Member

danielduan commented Apr 12, 2018

can you add a // eslint-disable-next-line no-unused-vars above that?

and then yarn test in root and update snapshots.

@codecov
Copy link

codecov bot commented Apr 13, 2018

Codecov Report

Merging #3409 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3409   +/-   ##
======================================
  Coverage    37.2%   37.2%           
======================================
  Files         463     463           
  Lines       10242   10242           
  Branches      894     926   +32     
======================================
  Hits         3811    3811           
+ Misses       5901    5877   -24     
- Partials      530     554   +24
Impacted Files Coverage Δ
lib/ui/src/modules/ui/configs/handle_routing.js 24.21% <0%> (ø) ⬆️
...dons/actions/src/lib/types/object/getObjectName.js 62.5% <0%> (ø) ⬆️
addons/actions/src/lib/util/omitProperty.js 75% <0%> (ø) ⬆️
lib/core/src/client/preview/syncUrlWithStore.js 40.9% <0%> (ø) ⬆️
addons/storyshots/src/vue/renderTree.js 60% <0%> (ø) ⬆️
addons/info/src/components/markdown/code.js 76.92% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/routed_link.js 22.72% <0%> (ø) ⬆️
addons/events/src/components/Event.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/shortcuts/actions/shortcuts.js 18.84% <0%> (ø) ⬆️
.../ui/components/stories_panel/stories_tree/index.js 40% <0%> (ø) ⬆️
... and 68 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d956d51...064f058. Read the comment docs.

@yi-ge
Copy link
Contributor Author

yi-ge commented Apr 13, 2018

@danielduan eslint-disable-line is great, but snapshots unable to pass test.

@danielduan
Copy link
Member

run yarn test --core --update, it should change some snapshots

@@ -21,7 +21,7 @@ storiesOf('Button', module)
}))
.add('with JSX', () => ({
components: { MyButton },
render() {
render(h) { // eslint-disable-line
Copy link
Member

@Hypnosphi Hypnosphi Apr 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use wildcard disables. Disable only the specific rule instead

@Hypnosphi
Copy link
Member

Please run yarn test --cli --update as well

@yi-ge
Copy link
Contributor Author

yi-ge commented Apr 16, 2018

@Hypnosphi I merge last master, run yarn test --cli --update, install @storybook/codemod, but I get it:

Detecting project type. ✓
 • Adding storybook support to your "React Native" app
     TypeError: Invalid Version: [object Object]
    at new SemVer (/Users/wangyi/Project/storybook/lib/cli/node_modules/semver/semver.js:291:11)
    at compare (/Users/wangyi/Project/storybook/lib/cli/node_modules/semver/semver.js:578:39)
    at gt (/Users/wangyi/Project/storybook/lib/cli/node_modules/semver/semver.js:607:10)

Excuse me? Could you do me a favor, please?

@Hypnosphi
Copy link
Member

Hypnosphi commented Apr 16, 2018

install @storybook/codemod

Weird, this shouldn't be needed. Did you run yarn bootstrap --core?

@yi-ge
Copy link
Contributor Author

yi-ge commented Apr 17, 2018

@Hypnosphi I have updated the snapshots. Thank you.

@danielduan danielduan merged commit 287a09d into storybookjs:master Apr 17, 2018
@Hypnosphi Hypnosphi added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Apr 28, 2018
Hypnosphi pushed a commit that referenced this pull request May 4, 2018
fixed Duplicate declaration h
@Hypnosphi Hypnosphi added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants