Reflect the new peer dependencies in docs and CLI templates #2714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hypnosphi
added
cli
patch:yes
joscha
reviewed
Jan 10, 2018
|
|
||
| Make sure that you have `react` and `react-dom` in your dependencies as well because we list these as a peerDependency: | ||
| Make sure that you have `react`, `react-dom`, and `babel-core` in your dependencies as well because we list these as a peerDependency: |
There was a problem hiding this comment.
I think this might read better as:
Make sure that you have `react`, `react-dom` in your dependencies and and `babel-core` in your devDependencies, because we list these as a peerDependency:
There was a problem hiding this comment.
If one has babel-core in their dependencies, it will work as well
There was a problem hiding this comment.
yes, but it reads as if babel-core needs to be an actual dependency, I guess I am too literal with the word dependencies 🤷♂️
Codecov Report
@@ Coverage Diff @@
## master #2714 +/- ##
=======================================
Coverage 34.35% 34.35%
=======================================
Files 390 390
Lines 8772 8772
Branches 909 907 -2
=======================================
Hits 3014 3014
- Misses 5135 5164 +29
+ Partials 623 594 -29
Continue to review full report at Codecov.
|
shilman
approved these changes
Jan 11, 2018
|
Looks like there's some kind of race condition, will fix |
shilman
pushed a commit
that referenced
this pull request
Jan 13, 2018
Reflect the new peer dependencies in docs and CLI templates
Hypnosphi
added
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: As someone has pointed out, both quick and slow start guides don't work currently, because they're missing the newly added peerDependencies