Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate @storybook/addon-storysource to strict ts #22367

Merged
merged 2 commits into from
May 7, 2023
Merged

Migrate @storybook/addon-storysource to strict ts #22367

merged 2 commits into from
May 7, 2023

Conversation

1234tgk
Copy link
Contributor

@1234tgk 1234tgk commented May 3, 2023 •
edited
Loading

Issue #22176

What I did

Adjust the code so that the package allows strict typing.

How to test

Run yarn check on @storybook/addon-viewbook directory.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@1234tgk 1234tgk force-pushed the ts-migrate/storysource branch from e3dbf7b to 661737e Compare May 3, 2023 13:26
@1234tgk 1234tgk requested a review from ryami333 May 3, 2023 13:26
@kasperpeulen kasperpeulen requested review from kasperpeulen and removed request for ryami333 May 3, 2023 14:36
@kasperpeulen kasperpeulen added the maintenance User-facing maintenance tasks label May 3, 2023
kasperpeulen
kasperpeulen requested changes May 4, 2023
View reviewed changes
Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I left some feedback :)

code/addons/storysource/src/StoryPanel.tsx Outdated Show resolved Hide resolved
code/addons/storysource/src/StoryPanel.tsx Outdated Show resolved Hide resolved
code/addons/storysource/src/StoryPanel.tsx Outdated Show resolved Hide resolved
@kasperpeulen kasperpeulen mentioned this pull request May 4, 2023
Closed
@1234tgk 1234tgk force-pushed the ts-migrate/storysource branch 2 times, most recently from 3069cc1 to 7f6f858 Compare May 4, 2023 10:16
@1234tgk 1234tgk requested review from kasperpeulen and ryami333 May 4, 2023 10:20
kasperpeulen
kasperpeulen approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! You seem to only need to update the lock file to pass the build.

@1234tgk
Copy link
Contributor Author

1234tgk commented May 4, 2023

@kasperpeulen Updated lock file, and all unit tests passed

@1234tgk 1234tgk force-pushed the ts-migrate/storysource branch from c2f2232 to a4d58f5 Compare May 5, 2023 22:27
@kasperpeulen kasperpeulen merged commit 451adc6 into storybookjs:next May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasperpeulen kasperpeulen kasperpeulen approved these changes

@ryami333 ryami333 Awaiting requested review from ryami333

Assignees
No one assigned
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@1234tgk @kasperpeulen @ryami333