Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Etoit/strict ts channels #22365

Merged
merged 2 commits into from
May 3, 2023
Merged

Etoit/strict ts channels #22365

merged 2 commits into from
May 3, 2023

Conversation

EDuToit
Copy link
Contributor

@EDuToit EDuToit commented May 2, 2023 •
edited
Loading

Closes #

What I did

Migrate @storybook/channels to strict-ts

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@EDuToit EDuToit force-pushed the etoit/strict-ts-channels branch from c1cb110 to 6281049 Compare May 2, 2023 22:13
@EDuToit EDuToit marked this pull request as ready for review May 2, 2023 22:14
@EDuToit EDuToit mentioned this pull request May 2, 2023
Closed
@kasperpeulen kasperpeulen self-requested a review May 3, 2023 10:42
@kasperpeulen kasperpeulen self-assigned this May 3, 2023
kasperpeulen
kasperpeulen approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kasperpeulen kasperpeulen added the maintenance User-facing maintenance tasks label May 3, 2023
@kasperpeulen kasperpeulen merged commit bb42cc1 into storybookjs:next May 3, 2023
@EDuToit EDuToit deleted the etoit/strict-ts-channels branch May 3, 2023 18:50
@EDuToit
Copy link
Contributor Author

EDuToit commented May 4, 2023

#22176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasperpeulen kasperpeulen kasperpeulen approved these changes

Assignees

@kasperpeulen kasperpeulen

Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EDuToit @kasperpeulen