Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Migrate @storybook/html-vite to strict TS #22293

Merged

Conversation

usrrname
Copy link
Contributor

@usrrname usrrname commented Apr 27, 2023

What I did

Part of #22176 migration to type-strictness for @storybook/html-vite:

  1. Change in tsconfig.json "strict": false -> "strict": true
  2. Run yarn check in the directory of the package.
  3. Fix all TS errors.

How to test

  1. run yarn task --task compile --no-link --start-from=install
  2. cd into code/frameworks/html-vite
    2.yarn check from project root
  3. Run yarn task --task dev --template html-vite/default-ts --start-from=auto to check everything still builds in sandbox
  4. Run e2e tests against dev sandbox yarn task --task e2e-tests-dev --template html-vite/default-ts
  5. Run yarn run test from root of codebase
  6. Run yarn run test:ci from root of codebase, drum fingers.... and wait for checking validity types nx run @storybook/html-vite:check to succeed.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes -- n/a
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@usrrname usrrname changed the title lint(tsconfig.json): update compilerOptions.strict from false => true #22176: lint(tsconfig.json): update compilerOptions.strict from false => true for @storybook/html-vite Apr 27, 2023
@usrrname usrrname force-pushed the feat/22176-html-vite-strict-ts branch 3 times, most recently from 277c0dd to 9461d84 Compare April 28, 2023 13:03
@usrrname usrrname changed the title #22176: lint(tsconfig.json): update compilerOptions.strict from false => true for @storybook/html-vite Build: Migrate@storybook/html-vite to strict TS Apr 28, 2023
@usrrname usrrname changed the title Build: Migrate@storybook/html-vite to strict TS Build: Migrate @storybook/html-vite to strict TS Apr 28, 2023
@usrrname usrrname force-pushed the feat/22176-html-vite-strict-ts branch 2 times, most recently from 8ca000b to c58b8f1 Compare April 29, 2023 20:46
@usrrname usrrname force-pushed the feat/22176-html-vite-strict-ts branch from c58b8f1 to 0ca6020 Compare April 30, 2023 16:10
@kasperpeulen kasperpeulen self-requested a review May 1, 2023 12:20
Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks!

@kasperpeulen kasperpeulen added the build Internal-facing build tooling & test updates label May 1, 2023
@kasperpeulen kasperpeulen self-assigned this May 1, 2023
@kasperpeulen kasperpeulen merged commit e6f33bc into storybookjs:next May 1, 2023
@usrrname usrrname deleted the feat/22176-html-vite-strict-ts branch May 1, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants