Build: Migrate @storybook/html-vite
to strict TS
#22293
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Part of #22176 migration to type-strictness for
@storybook/html-vite
:How to test
yarn task --task compile --no-link --start-from=install
code/frameworks/html-vite
2.
yarn check
from project rootyarn task --task dev --template html-vite/default-ts --start-from=auto
to check everything still builds in sandboxyarn task --task e2e-tests-dev --template html-vite/default-ts
yarn run test
from root of codebaseyarn run test:ci
from root of codebase, drum fingers.... and wait for checking validity typesnx run @storybook/html-vite:check
to succeed.Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]