Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue3: Fix compiler error when there is double tag #22286

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

chakAs3
Copy link
Contributor

@chakAs3 chakAs3 commented Apr 27, 2023

Closes #

What I did

fix compiler error when there is double tag

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@chakAs3 chakAs3 self-assigned this Apr 27, 2023
@chakAs3 chakAs3 requested a review from JReinhold April 27, 2023 13:12
@chakAs3
Copy link
Contributor Author

chakAs3 commented Apr 27, 2023

Hi @JReinhold, can you approve this quickly, babal parser has issue if there is double tag in the template <tag><tag></tag></tag>
i'm catching the exception but using console.Error breaks sometimes better removed it

@JReinhold
Copy link
Contributor

using console.Error breaks sometimes better removed it

I'm not sure I understand this part, can you explain?

@chakAs3
Copy link
Contributor Author

chakAs3 commented Apr 27, 2023

using console.Error breaks sometimes better removed it

I'm not sure I understand this part, can you explain?

const ast = parserHTML.parsers.vue.parse(renderFn.toString());

babel throws an exception if there is double tag in the template, anyway i removing babel in the next PR adressing source decorator.

this is just fix cause it is blocking some users

im just commenting the line with console.Error you can check the changed files.

@shilman can you approve and merge this before your release if @JReinhold left for the day

@chakAs3 chakAs3 added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Apr 27, 2023
@ReactiveCoderHK
Copy link

i got the same issue is it in v7 ?

@shilman shilman changed the title vue3: fix compiler error when there is double tag Vue3: Fix compiler error when there is double tag Apr 27, 2023
@shilman shilman merged commit 9e8fb26 into next Apr 27, 2023
@shilman shilman deleted the chaks/vue3-fix-double-tag-issue branch April 27, 2023 18:41
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 3, 2023
shilman added a commit that referenced this pull request May 3, 2023
…issue

Vue3: Fix compiler error when there is double tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch vue3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants