Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved Vue3 TS Stories into a separate folder #22235

Merged
merged 4 commits into from
Apr 25, 2023
Merged

Moved Vue3 TS Stories into a separate folder #22235

merged 4 commits into from
Apr 25, 2023

Conversation

valentinpalkovic
Copy link
Contributor

Closes N/A

What I did

Moved Vue3 TS Stories into a separate folder, because TS Stories are not applicable to all Vue3 sandboxes

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@valentinpalkovic valentinpalkovic self-assigned this Apr 24, 2023
@valentinpalkovic valentinpalkovic added bug maintenance User-facing maintenance tasks ci:daily Run the CI jobs that normally run in the daily job. and removed bug labels Apr 24, 2023
@valentinpalkovic valentinpalkovic force-pushed the valentin/move-vue3-ts-stories-to-separate-folder branch from 782f47d to 5cb8be8 Compare April 25, 2023 06:49
kasperpeulen
kasperpeulen approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@valentinpalkovic valentinpalkovic force-pushed the valentin/move-vue3-ts-stories-to-separate-folder branch from 5cb8be8 to cbe0604 Compare April 25, 2023 10:19
@valentinpalkovic valentinpalkovic merged commit 163dbe8 into next Apr 25, 2023
@valentinpalkovic valentinpalkovic deleted the valentin/move-vue3-ts-stories-to-separate-folder branch April 25, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannbf yannbf yannbf left review comments

@kasperpeulen kasperpeulen kasperpeulen approved these changes

Assignees

@valentinpalkovic valentinpalkovic

Labels
ci:daily Run the CI jobs that normally run in the daily job. maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@valentinpalkovic @kasperpeulen @yannbf