Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Upgrade Playwright to 1.32.3 #22087

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Build: Upgrade Playwright to 1.32.3 #22087

merged 1 commit into from
Apr 18, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Apr 14, 2023 •
edited
Loading

What I did

Upgraded Playwright to 1.32.3, check announcement video here.

How to test

  1. Run e2e-tests by prepending DEBUG=1 for a template, e.g. DEBUG=1 yarn task --task e2e-tests-dev --start-from auto --template react-vite/default-ts --junit
  2. Get a nice experience like so

image

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@yannbf yannbf added the build Internal-facing build tooling & test updates label Apr 14, 2023
@storybookjs storybookjs deleted a comment from socket-security bot Apr 14, 2023
@valentinpalkovic valentinpalkovic self-assigned this Apr 17, 2023
@valentinpalkovic valentinpalkovic self-requested a review April 17, 2023 14:35
@valentinpalkovic valentinpalkovic added the ci:daily Run the CI jobs that normally run in the daily job. label Apr 17, 2023
@yannbf yannbf added patch:yes Bugfix & documentation PR that need to be picked to main branch and removed ci:daily Run the CI jobs that normally run in the daily job. labels Apr 18, 2023
@yannbf yannbf merged commit 837bca2 into next Apr 18, 2023
@yannbf yannbf deleted the build/upgrade-playwright branch April 18, 2023 10:04
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 18, 2023
shilman pushed a commit that referenced this pull request Apr 18, 2023
@yannbf @shilman
Merge pull request #22087 from storybookjs/build/upgrade-playwright
a07ed71 
Build: Upgrade Playwright to 1.32.3
@dannyhw dannyhw mentioned this pull request Feb 5, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentinpalkovic valentinpalkovic valentinpalkovic approved these changes

Assignees

@yannbf yannbf

Labels
build Internal-facing build tooling & test updates patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yannbf @valentinpalkovic @shilman